Add Mix compiler that raises on missing parsetools #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a `:ensure_yecc_compiler` Mix compiler that raises when the `:yecc` module is missing (because the `:parsetools` Erlang application is missing). This should help a lot with issue #67.
|
I think we are covered with elixir-lang/elixir@737bf1b. |
|
Yup, this has been fixed in Elixir. :) |
|
Whoops, I saw that but didn't think it was this recent, I somehow just thought it didn't trigger for Gettext for some reason :\ Great then! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is a good idea or, if it is, if this is the way to go. I added an
:ensure_yecc_compilerMix compiler that raises when the:yeccmodule is missing (because the:parsetoolsErlang application is missing). This should help a lot with issue #67 and phoenixframework/phoenix#1411.