Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Xgit.DirCache.DirCacheEntry. #151

Merged
merged 25 commits into from
Jun 8, 2019
Merged

Implement Xgit.DirCache.DirCacheEntry. #151

merged 25 commits into from
Jun 8, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented May 27, 2019

Changes in This Pull Request

Port the jgit class DirCacheEntry.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes.
  • Any code ported from jgit maintains all existing copyright notices.
  • The Eclipse Distribution License header text is included in all new source files.
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@scouten
Set up to port DirCacheEntry.
715a036
@scouten
Note about how to port DirCacheEditor when we get there.
4fb1a67
@scouten
Design the struct.
f8c4dad 
All instances of mutation of this Java class that I can find occur between construction and hand-off of the reference, so we can safely treat the underlying struct in Xgit as immutable.
@scouten scouten self-assigned this May 27, 2019
@scouten scouten added this to In progress in (DEFERRED) Implement `git add` via automation May 27, 2019
@scouten scouten added this to In progress in PLUMBING: Implement RevWalk. via automation Jun 6, 2019
scouten added 14 commits June 6, 2019 08:44
@scouten
Merge branch 'master' into dir-cache-entry
5bb92eb 
* master:
  Let's target infrastructure / plumbing for now. First up: RevWalk. (#155)

# Conflicts:
#	notes/porting_roadmap.txt
@scouten
Construct with stage.
00b0dd7
@scouten
WIP on set_file_mode/2.
1d3a24f 
Need implementation of NB.encode_int32/1.
@scouten
Merge branch 'master' into dir-cache-entry
95ace4e 
* master:
  Implement NB.encode_int32/1. (#156)
@scouten
Minor fix-ups.
088a5a1
@scouten
Tests for set_file_mode.
6c5e706
@scouten
Implement assume_valid flag.
63edb2c
@scouten
Let's be consistent about path being a charlist.
a8b18b5
@scouten
Make clear that set_* functions are returning a new entry.
b48ab7d
@scouten
Implement creation_time and set_creation_time.
9fe0294
@scouten
Implement last_modified_time and set_last_modified_time.
4bd08fa
@scouten
Cover the edge case of name > 64 chars.
c2600ca
@scouten
No, really, I want that last line covered!
c83bfb7
@scouten
Punting on remaining edge cases. Add link to GitHub issue.
8465c83
@scouten scouten merged commit 69f7fdb into master Jun 8, 2019
PLUMBING: Implement RevWalk. automation moved this from In progress to Done Jun 8, 2019
@scouten scouten deleted the dir-cache-entry branch June 8, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scouten scouten

Labels
None yet
Projects
PLUMBING: Implement RevWalk.
  
Done
(DEFERRED) Implement `git add`
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@scouten