Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Add validate? option to HashObject. #42

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Jul 22, 2019

Changes in This Pull Request

Adds object validation to Xgit.Plumbing.HashObject.

Defaults to true, but you can use validate?: false to bypass validation.

Also change return options to :ok / :error tuples.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes.
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

Default to true, but you can use `validate?: false` to bypass validation.

Also change return options to :ok / :error tuples.
@scouten scouten self-assigned this Jul 22, 2019
@scouten scouten merged commit 89f426a into master Jul 22, 2019
@scouten scouten deleted the hash_object+validate branch July 22, 2019 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant