feature: introduce get cert #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamorim
force-pushed
the
feature/introduce-get-cert
branch
from
9a178b2
to
46ab200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this code! Awesome work.
This is similar to #119, but for
:cowboy_req.cert/1The motivation behind came because I'm implementing a IoT system and wanted to use Mutual TLS to identify the device, using the Common Name for that.
For that, I needed access to the client certificate so I could fetch the CN and finally uniquely identify the device, but gRPC didn't gave me access to the client certificate, so I ended up implementing this PR.
I still need to test that it returns the client certificate, but that would require me generating client keys and stuff, and it is already pretty late here, so I'll leave for another day.
Wanted to create the PR to check if you are interested in this.
Cheers