Update gun to 2.0 #301
Update gun to 2.0 #301
Conversation
|
cowboy with cowlib is finally updated so this can be merged. |
|
@carrascoacd (cc @nulian) The tests are currently failing on CI due to some SSL validation issues. Any ideas on how to fix that? Locally everything works. |
|
I'm afraid it is because |
What's weird to me is that Elixir 1.14 + OTP 25 works fine locally for me, without changing anything. |
|
Yes, it is quite weird. Maybe I'm wrong and it is backwards compatible. Can you check the runtime GH uses in the tests to use exactly that instead of asdf based? |
|
Great news, it seems that the SSL issues appear on Erlang 25.3, so using 25.1.x (which is the same I had locally) solves this for now, so we'll be able to merge |
|
Great! Good job |
We're stuck on trying to use mixNixDeps instead of mixFodDeps, due to:
[nix-shell:~/prog/mool/package]$ make build-mool-server
nix-build build.nix --option sandbox relaxed --show-trace -A mool-server --out-link mool-server
this derivation will be built:
/nix/store/575p9jk7sj28pxam4c07i99vmazqj7mb-mool-server-0-dev.drv
building '/nix/store/575p9jk7sj28pxam4c07i99vmazqj7mb-mool-server-0-dev.drv'...
unpacking sources
unpacking source archive /nix/store/xfjidpmkk2cfc1hmf26fv4yja602b27p-mool-server
source root is mool-server
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
extracting mool-nifs
building
Compiling 14 files (.ex)
Generated mools app
installing
** (Mix) Could not find application :gun
error: builder for '/nix/store/575p9jk7sj28pxam4c07i99vmazqj7mb-mool-server-0-dev.drv' failed with exit code 1;
last 10 log lines:
> source root is mool-server
> patching sources
> updateAutotoolsGnuConfigScriptsPhase
> configuring
> extracting mool-nifs
> building
> Compiling 14 files (.ex)
> Generated mools app
> installing
> ** (Mix) Could not find application :gun
For full logs, run 'nix log /nix/store/575p9jk7sj28pxam4c07i99vmazqj7mb-mool-server-0-dev.drv'.
make: *** [Makefile:25: build-mool-server] Error 1
But this may become moot once elixir-grpc upgrades to just using `gun`
instead of the `grpc_gun` wrapper. See elixir-grpc/grpc#301
Context
Gun 2.0 has been released. As a consequence, the dependency resolution when using https://github.com/elixir-grpc/grpc is broken.
In order to remove the temporal fork of
gunand use the officialgunlibrary, we want to make sure that:gundepends oncowlib2.12.0cowboydepends oncowlib2.12.0grpcdepends indirectly on oncowlib2.12.0I'm also taking the chance for releasing the minor version of the dependency so we are not so strict.
Related to ninenines/cowboy#1601 @essen @polvalente