Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ecto.DateTime and Ecto.Time to have usec #491

Closed
josevalim opened this issue Mar 2, 2015 · 6 comments
Closed

Update Ecto.DateTime and Ecto.Time to have usec #491

josevalim opened this issue Mar 2, 2015 · 6 comments

Comments

@josevalim
Copy link
Member

Today we already receive usec information from the database, we just need to change parsing and update our structs. Let's do this after 0.9 is out though to avoid too many changes in the same release.

@josevalim
Copy link
Member Author

This is now ready for tackling! /cc @briksoftware @whatyouhide

@whatyouhide
Copy link
Contributor

I'd like to have a shot at this tomorrow if that's okay :).

@lau
Copy link
Contributor

lau commented Mar 5, 2015

u != μ

Can we call microseconds something other than usec?

μ is the lower case version of a greek M. Pronounced a bit like "me" in English or "mi" en Spanish.
see https://en.wikipedia.org/wiki/Mu_%28letter%29

My suggestion: microsec

I know that some people have used usec before in other languages. But this is a new project and we have a chance to correct it.

@ericmj
Copy link
Member

ericmj commented Mar 5, 2015

And microsec != micro_seconds :). Using u instead of μ is just fine imo. If you understand μsec you should also understand usec given the context.

@josevalim
Copy link
Member Author

The unified code for units actually specifies u can be used in case sensitive scenarios where only the ascii codepoints is available: http://unitsofmeasure.org/ucum.html (section 4.1, no direct link, sorry).

More about the code: http://en.wikipedia.org/wiki/Unified_Code_for_Units_of_Measure

@lau
Copy link
Contributor

lau commented Mar 5, 2015

OK, I won't argue with the unified code for units of measure. I will also change the struct in Kalends from microsec to usec for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants