Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception.normalize should receive optional stacktrace #2151

Closed
ericmj opened this issue Apr 4, 2014 · 1 comment
Closed

Exception.normalize should receive optional stacktrace #2151

ericmj opened this issue Apr 4, 2014 · 1 comment
Labels
App:Elixir Kind:Enhancement Level:Starter

Comments

@ericmj
Copy link
Member

ericmj commented Apr 4, 2014

Normalization is unreliable unless it is performed at the start of a catch (it may get the wrong stacktrace). Additionally, the kind argument should be made required.

Wait with this until 0.13 is out.
@ericmj ericmj modified the milestone: 0.12.1 Apr 4, 2014
@josevalim
Copy link
Member

Basically, some clauses of Exception.normalize/2 expect a stacktrace and we should allow it to be given as argument. In those clauses, we then do stacktrace || System.stacktrace.

@fishcakez fishcakez mentioned this issue May 3, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App:Elixir Kind:Enhancement Level:Starter
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josevalim @ericmj