New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering modules from coverage using regex #10954
Merged
josevalim
merged 4 commits into
elixir-lang:master
from
hauleth:ft/filter-modules-from-coverage-using-regex
May 20, 2021
Merged
Allow filtering modules from coverage using regex #10954
josevalim
merged 4 commits into
elixir-lang:master
from
hauleth:ft/filter-modules-from-coverage-using-regex
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need docs and tests. :) |
Ping! :) |
I will handle it today or over the weekend. |
hauleth
force-pushed
the
ft/filter-modules-from-coverage-using-regex
branch
from
May 19, 2021 10:35
dce3521
to
d3e620c
Compare
This can be handy in case of many generated modules (in my case it was `Cldr` module containing a lot of generated code) and protocol modules that aren't really interesting for our application (for example `Inspect` protocol when filtering out fields like passwords).
hauleth
force-pushed
the
ft/filter-modules-from-coverage-using-regex
branch
from
May 20, 2021 10:15
d3e620c
to
c97a5f4
Compare
@josevalim done with tests. |
josevalim
reviewed
May 20, 2021
Co-authored-by: José Valim <jose.valim@gmail.com>
josevalim
reviewed
May 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have suggested one tiny refactoring. Then we need docs and we should be good to go!
Added docs. |
fertapric
reviewed
May 20, 2021
josevalim
reviewed
May 20, 2021
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be handy in case of many generated modules (in my case it was
Cldr
module containing a lot of generated code) and protocol modules that aren't really interesting for our application (for exampleInspect
protocol when filtering out fields like passwords).