Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering modules from coverage using regex #10954

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Apr 25, 2021

This can be handy in case of many generated modules (in my case it was Cldr module containing a lot of generated code) and protocol modules that aren't really interesting for our application (for example Inspect protocol when filtering out fields like passwords).

@josevalim
Copy link
Member

We need docs and tests. :)

@josevalim
Copy link
Member

Ping! :)

@hauleth
Copy link
Contributor Author

hauleth commented May 14, 2021

I will handle it today or over the weekend.

@hauleth hauleth force-pushed the ft/filter-modules-from-coverage-using-regex branch from dce3521 to d3e620c Compare May 19, 2021 10:35
This can be handy in case of many generated modules (in my case it was
`Cldr` module containing a lot of generated code) and protocol modules
that aren't really interesting for our application (for example
`Inspect` protocol when filtering out fields like passwords).
@hauleth hauleth force-pushed the ft/filter-modules-from-coverage-using-regex branch from d3e620c to c97a5f4 Compare May 20, 2021 10:15
@hauleth
Copy link
Contributor Author

hauleth commented May 20, 2021

@josevalim done with tests.

Co-authored-by: José Valim <jose.valim@gmail.com>
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have suggested one tiny refactoring. Then we need docs and we should be good to go!

@hauleth
Copy link
Contributor Author

hauleth commented May 20, 2021

Added docs.

@josevalim josevalim merged commit a5fd7d6 into elixir-lang:master May 20, 2021
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@hauleth hauleth deleted the ft/filter-modules-from-coverage-using-regex branch May 20, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants