Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenizer uses static_atoms_encoder on quoted keys 3ae53ac #11313

Merged
merged 4 commits into from Oct 15, 2021
Merged

Tokenizer uses static_atoms_encoder on quoted keys 3ae53ac #11313

merged 4 commits into from Oct 15, 2021

Conversation

sabiwara
Copy link
Contributor

Make the tokenizer call static_atoms_encoder on quoted keys.

Question: I re-used kw_identifier, should I introduce a new one like kw_identifier_quoted to be consistent with atom_qoted?

Closes #11312

@josevalim josevalim merged commit 8203cf1 into elixir-lang:master Oct 15, 2021
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@sabiwara sabiwara deleted the fix-static-atoms-encoder branch October 15, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code.string_to_quoted/2 static_atoms_encoder is not called for quoted keys
2 participants
@sabiwara @josevalim