Allow passing extra arguments to eval release command

[hauleth]

It is handy for writing custom actions to communicate and operate with the release.

[josevalim]

@wojtekmach, I assume we discussed this at some point but I can't quite recall. Or did we run into issues with RPC?

@hauleth we would also need to support this on mix eval and add a test. :)

[hauleth]

At first I added it to mix eval as well, but I wasn't sure it will work. First I need to make it work on Windows, but I know nothing about Batch so I am testing how I can make it work.

[josevalim]

@hauleth I believe you can change System.argv on the fly. Or perhaps see how mix run does it.

[wojtekmach]

@josevalim I don't think we ever tackled bin/app eval. We were mostly concerned about bin/app start (#11426 (comment)) and a new bin/app rpc MOD FUN ...ARGS (#11661)

[josevalim]

LGTM! We just need to address mix eval and we are good to go.

[hauleth]

Ehhhh… Do we need to support Batch? Cannot we support PowerShell on Windows instead?

https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/shift

The shift command has no effect on the %* batch parameter.

Ok, so looping, here we go.

[wojtekmach]

We can’t default to .ps1 as executing these is disabled by default on Windows. (ikr.)

[hauleth]

@josevalim eval is done, the rpc is not, but honestly I do not know if that is something we should do. The thing is that rpc is called in context of the application, so that mean that we would not be able to do rpc "IO.inspect(System.argv())" to get the args that were passed to start command. I think that eval is the only one where it is sensible to have access to passed args. For rpc there would be another mechanism needed for that.

[josevalim]

Yup. We cannot do rpc.

[hauleth]

So now it is ready, works on Windows (at least tests says so) and on *nixes.

[josevalim]

Thank you @hauleth! We just need to support the same on the new mix eval task and we are good!

[hauleth]

There is new command for mix beyond mix run? Ok, I will take a look.

[josevalim]

mix eval was designed to mirror the VM state from bin/app eval to make it easier for testing and reuse!

[hauleth]

Added the support for arguments in mix eval

[josevalim]

💚 💙 💜 💛 ❤️