Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ex_doc admonition blocks when possible #12445

Merged
merged 2 commits into from Mar 5, 2023
Merged

Use ex_doc admonition blocks when possible #12445

merged 2 commits into from Mar 5, 2023

Conversation

whatyouhide
Copy link
Member

No description provided.

josevalim
josevalim reviewed Mar 4, 2023
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should change the casing. We don't use titlecase anywhere in Elixir, so "Avoiding the Application Environment" should be "Avoiding the application environment" and so on.

@whatyouhide
Copy link
Member Author

Ah good to know, I thought we did for section titles. Will do and merge then 😌

josevalim
josevalim reviewed Mar 5, 2023
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, also look for > **. But in another PR?

@whatyouhide whatyouhide merged commit 2b1a768 into main Mar 5, 2023
@whatyouhide whatyouhide deleted the al/admonition branch March 5, 2023 13:44
@whatyouhide
Copy link
Member Author

@josevalim done in a20da2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whatyouhide @josevalim