Fix column number of map's opening bracket #13601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won’t this break map meta in AST? It was recently fixed in fd4e6b5. Before 1.17 meta column was off by one. |
Yes, the PR you reference introduced this bug. It seems kind of obviously wrong when you read it. If But I am quite ignorant about all of this. I especially lack awareness of the larger context. |
|
The tokenizer is 100% private API. We don’t guarantee compatibility on its output and no project should invoke it. The column positions are used internally for our needs. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help finish
rrrene/credo#1136
To fix rrrene/credo#1132