Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification of aliases' non-visibility if defined in dependency #5393

Closed
wants to merge 1 commit into from
Closed

Clarification of aliases' non-visibility if defined in dependency #5393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/mix/lib/mix.ex
View file
Open in desktop
Expand Up @@ -148,7 +148,9 @@ defmodule Mix do
Where `&clean_extra/1` would be a function in your `mix.exs`
with extra clean up logic.

Note aliases do not show up on `mix help`.
Note:
* aliases do not show up on `mix help`
* aliases are not merged in from the `mix.ex` files of dependent project definitions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write this as a sentence instead of a list?

A dependent project would be a parent project, I think you mean a dependencies project definitions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so do you mean something like this ?

Note aliases do not show up on `mix help`. 
Aliases are not merged in from the `mix.ex` files of project dependencies.

Edit: will recreate PR if you approve

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like: "Aliases defined in the current project does not affect its dependencies and aliases defined in dependencies are not accessible from the current project."?


## Environment variables

Expand Down