Use :extra_applications instead of :applications in escript.build

[whatyouhide]

I wonder, could this veeery simple change be a solution for #5529? 🤔 :)

[josevalim]

You need to get both and concatenate tchem together with ++. We can use Keyword.get/3 with a default of an empty list.

…

On Sun, Dec 4, 2016 at 21:50 Andrea Leopardi ***@***.***> wrote: I wonder, could this veeery simple change be a solution for #5529 <#5529>? 🤔 :) ------------------------------ You can view, comment on, or merge this pull request online at: #5534 Commit Summary - Use :extra_applications instead of :applications in escript.build File Changes - *M* lib/mix/lib/mix/tasks/escript.build.ex <https://github.com/elixir-lang/elixir/pull/5534/files#diff-0> (2) Patch Links: - https://github.com/elixir-lang/elixir/pull/5534.patch - https://github.com/elixir-lang/elixir/pull/5534.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5534>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAlbvSbk-zLmcvlG44-UY0k1cS_Dftlks5rEyecgaJpZM4LDsUY> .

[josevalim]

We should probably change an existing escritp test to use extra_applications.

[whatyouhide]

@josevalim I implemented both suggestions. While changing the test related to this in particular:

  defmodule EscriptErlangWithDeps do
    def project do
      [app: :escripttesterlangwithdeps,
       version: "0.0.1",
       language: :erlang,
       escript: [main_module: :escripttest],
       deps: [{:ok, path: fixture_path("deps_status/deps/ok")}]]
    end

    def application do
      [applications: []]
    end
  end

I left :applications to [] since we don't want to bring the :ok application in the escript as that would require to embed Elixir. Out of curiosity, I tried using applications: [:ok] and escript: [embed_elixir: true] and it in fact worked, but then I tried applications: [:ok], extra_applications: [:elixir] (with embed_elixir: false) and it didn't work, failing to load the :elixir application; is this expected and I'm missing something? I know about the docs of escript.build that say

you will have to add paths to Elixir’s ebin directories to ERL_LIBS environment variable when running the resulting escript, in order for the code loader to be able to find :elixir application and its children applications (if they are used).

but I expected that putting :elixir in the :extra_applications would do the trick anyways, but here we don't do anything about extra applications for Erlang escripts.

Sorry for the convoluted wall of text, hope my questions are clear enough 😄

[josevalim]

but I expected that putting :elixir in the :extra_applications would do the trick anyways,

No because we change the escript generated based on the language configuration. Basically, you never add :elixir to :extra_applications, Mix takes care of it for you.

[josevalim]

I guess though you found a bug in that if someone depends on logger and not the parent project, :logger won't be included after all. I think we should open up a separete report for it though, it is not related to this bug per se, as it likely exists since the beginning of escript.build (and this one is a regression).

[whatyouhide]

@josevalim ok, got it. I will investigate and open another bug for that. Regarding this PR, do we need to change anything else?

[josevalim]

Looks good to me! Please backport to v1.4!

[whatyouhide]

Awesome, backported to v1.4 as well.