Fix redefined function source location #5720
Conversation
| test "unused variable in redefined function in different file" do | ||
| output = capture_err(fn -> | ||
| Code.eval_string """ | ||
| defmodule Sample do |
There was a problem hiding this comment.
Let's use the supervisor example as a test so we don't need to define a separate fixture file. :)
There was a problem hiding this comment.
Not sure I understand what you mean by "use the supervisor example". I can't find an existing fixture that has a redefinition of a function from a different source. I can avoid the eval_string by change the fixture file to use supervisor, but this would still require having a fixture file.
There was a problem hiding this comment.
Wouldn't this be enough to have a warning?
Code.eval_string """
defmodule Sample do
use Supervisor
def init(params) do
end
end
"""
There was a problem hiding this comment.
This code does expose the bug because the warning would refer to no_file:3 instead of supervisor.ex:5.
I like the assertion assert output =~ "redefine_sample.ex:3" better because it seems more expressive and less brittle.
There was a problem hiding this comment.
So you can pass :file option to eval_string if that's the case. No need for a fixture file. :)
There was a problem hiding this comment.
Oh great. That is definitely better..
Pulling in Supervisor might make following the intention of the test setup harder
What about this version?
| check_valid_kind(Ann, File, Name, Arity, Kind, StoredKind), | ||
| (Check and StoredCheck) andalso | ||
| check_valid_clause(Ann, File, Name, Arity, Kind, Data, StoredAnn, StoredFile), | ||
| check_valid_defaults(Ann, File, Name, Arity, Kind, Defaults, StoredDefaults, LastDefaults, LastHasBody), | ||
| {StoredAnn, StoredLocation, {max(Defaults, StoredDefaults), HasBody, Defaults}}; | ||
| {StoredAnn, Location, {max(Defaults, StoredDefaults), HasBody, Defaults}}; |
When functions are redefined in a different file, the translation uses the first definition source location for all subsequent definitions. This manifests itself as warnings that are ascribed to the wrong file. Fixes #5719
|
❤️ 💚 💙 💛 💜 |
When functions are redefined in a different file, the translation uses the first definition source location for all subsequent definitions. This manifests itself as warnings that are ascribed to the wrong file. Fixes #5719 Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
When functions are redefined in a different file, the translation uses
the first definition source location for all subsequent definitions.
This manifests itself as warnings that are ascribed to the wrong file.
Fixes #5719