Add specs for compilers to return diagnostic info from run/1 #6280
Conversation
|
@michalmuskala @josevalim, this PR has been open for more than a month. It's fairly small, and getting it in would unblock me from adding these diagnostics to Mix's compilers. I'd appreciate if someone could find the time to review it. Thanks! |
|
Apologies @JakeBecker! This completely fell through the cracks. This PR looks good to me but it is too abstract. I would like to see at least one compiler converted to it so we could understand how the new contract would be used. Do you think it is possible? Thank you! ❤️ |
|
Sounds good to me, I'll add an implementation to the PR. |
…r 1-based line numbers
JakeBecker
force-pushed
the
compiler-diagnostics
branch
from
0a53df8
to
56d8164
Compare
|
@josevalim I implemented the diagnostic return values for the Elixir compiler. I also changed the spec for the diagnostics a bit. Please take a look. Thanks! |
I preserved the previous default behaviour of killing the process when encountering compile errors, since that seems important when launching a Mix task from the CLI. You can pass a CLI option `--return-errors` if you don't want to kill the process and instead return the diagnostics.
|
@josevalim I added commits that modify I preserved the previous default behaviour of killing the process when encountering compile errors, since that seems important when launching a Mix task from the CLI. You can pass a CLI option Please review. Thanks! |
|
I'm closing this to break it up into smaller PRs that will be easier to review. |
This was motivated by ElixirLS and was influenced by the Language Server Protocol's specification for diagnostics.
I expect people might have strong opinions. I'm eager for feedback :)