Default System.cmd to File.cwd to fix running on slave nodes #8278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
System.cmd
in a slave node without passingcd: File.cwd!
will use the current working directory of the master node and not the slave node.For example:
If you start a slave node and use
File.cd "/somewhere"
and thenSystem.cmd("pwd", [])
the returned result will be that of the master node and not/somewhere
. This is problematic especially because of the use ofFile.cd!/2
where calls in the function expect this to work.