Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing code changes on GenStage documentation #210 #211

Merged
merged 2 commits into from Jun 26, 2018

Conversation

alvaromlg
Copy link
Contributor

Pull request for #210
Without these code changes I receive the error

** (Mix) Could not start application testdep: Application.start(:normal, []) returned an error: shutdown: failed to start child: B
    ** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started

After applying the code changes on start_link/1 the application starts correctly and starts counting:

iex(1)> [0, 2, 4, 6, 8]
[10, 12, 14, 16, 18]
[20, 22, 24, 26, 28]
[30, 32, 34, 36, 38]

I didnt suggest to add the named module on consumer GenStage.start_link(C, :ok) because nobody is going to subscribe to the consumer but maybe is a good practice to always name the process, I am not sure about that.

@josevalim josevalim merged commit 1630358 into elixir-lang:master Jun 26, 2018
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants