Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for textEdit #28

Open
axelson opened this issue May 26, 2019 · 2 comments
Open

Add support for textEdit #28

axelson opened this issue May 26, 2019 · 2 comments
Labels
enhancement New feature or request long term

Comments

@axelson
Copy link
Member

axelson commented May 26, 2019

Related issue: #27

insertText is deprecated because it is too open to interpretation and not precise enough. Instead we should support textEdit
@axelson axelson mentioned this issue May 26, 2019
Closed
@axelson axelson mentioned this issue May 30, 2020
Merged
@lukaszsamson
Copy link
Collaborator

As of 3.15 (and upcoming 3.16) insertText is no longer deprecated. The spec now only recommends using texEdit and a lot of other are being introduced to this APIs

@axelson axelson changed the title Add support for textEdit since insertText is deprecated Add support for textEdit Dec 12, 2020
@axelson axelson added the enhancement New feature or request label Dec 12, 2020
@axelson
Copy link
Member Author

axelson commented Dec 12, 2020

Good point, updated the title

@princemaple princemaple mentioned this issue Feb 23, 2021
Closed
2 tasks
@axelson axelson mentioned this issue Jul 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request long term
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axelson @lukaszsamson