-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work on elixir 1.10 #92
Comments
Things like Mix.State is also a private API, so please don't continue using private APIs. Open up an issue so we provide a public API for you to call. About the dialyzer one, please provide a project that reproduces the error. I am assuming |
@lukaszsamson thanks for putting this list together and tracking down these issues! @josevalim Posted on elixir-lang-core https://groups.google.com/forum/#!topic/elixir-lang-core/_LrWhl-kUZY (although re-reading your comment, perhaps I should have just raised an issue directly). Although in either case, this is just one of the private api usages, I'll try and do a sweep to look for the others. |
@josevalim I looked deeper into dialyzer issue. It turns out that dialyzer is not required to trigger it at all and it might be a consequence of the fixtures used in this project. I am able to reproduce from the root of this repo
It seems that the protocol defined upper in directory hierarchy ends up in the fixture dir |
I am looking into this now. Thank you so much for isolating those, it makes my life much easier! |
@lukaszsamson so the command above compiled just fine for me. I am thinking you have some stale files somewhere. Try running |
@josevalim yes, it must have been some stale state. I remember doing |
@lukaszsamson regarding "tests crash mix" I'm actually seeing that same error locally on 1.9.1, it's just not failing the CI builds. |
Yep, I can confirm it also on 1.9.4. I'm going to create a separate isse. |
elixir-sense version not compatible - bump to incorporate fixes from
elixir-lsp/elixir_sense@59fe051
elixir-lsp/elixir_sense@8b54a77
elixir-lsp/elixir_sense@fc8f326
elixir-lsp/elixir_sense@1e528d6
elixir-lsp/elixir_sense@5f25922
elixir-lsp/elixir_sense@1aa09ab
Bump elixir_sense again #87
Expand unit tests fail on elixir 1.10 elixir_sense#76 needs fixing
References broken on elixir 1.10 elixir_sense#75 needs fixing
dialyzer tests failing - asked for help on elixir-forum https://elixirforum.com/t/elixir-v1-10-0-rc-0-released/28086/42
clear_cache moved to Mix.State clear_cache moved to Mix.State on elixir 1.10 #91
Code.load_file/1 is deprecated Remove elixir 1.6 code as 1.7 is required #93
tests crash mixmoved to Mix process crashing in tests #100The text was updated successfully, but these errors were encountered: