Rework wrapper scripts a bit #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobbZ
reviewed
Apr 8, 2020
|
|
||
| did_relaunch=$1 | ||
|
|
||
| asdf_vm="${HOME}/.asdf/asdf.sh" |
There was a problem hiding this comment.
Am I missing something or will this only work for "user" installations, but not for system wide ones?
Eg. the Arch Linux package puts that script to /opt/asdf-vm/asdf.sh.
There was a problem hiding this comment.
I don't think that asdf is geared towards system-wide installation. The installation instructions all refer to $HOME/.asdf: https://asdf-vm.com/#/core-manage-asdf-vm
If you want to setup asdf for a non-standard configuration, I would think that editing ~/.config/elixir_ls/setup.sh would be a good solution.
This was referenced Apr 8, 2020
jswny
reviewed
Apr 8, 2020
| # give them the chance here. ELS_MODE will be set for | ||
| # the really complex stuff. Use an XDG compliant path. | ||
|
|
||
| els_setup="${HOME}/.config/elixir_ls/setup.sh" |
There was a problem hiding this comment.
If you are trying to properly support XDG, this should be able to read from $XDG_CONFIG_HOME, or use $HOME/.config if that variable is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: currently just for review of the scripts, I want to do some more testing and also document theRoughly as discussed on Slack. This will do the right thing on, say, docker containers that only have a minimal Posix shell but also use asdf-vm when available; on top of that, added a hook that will allow kiex/... users to make sure the scripts do what they want.~/.elixir_ls_setup.shscript.