Remove the default .tool-versions file #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsamson
approved these changes
Aug 20, 2020
By removing the .tool-versions file it makes it easier for users to use their system installed elixir and erlang versions. There is some related discussion in elixir-lsp#344 but most of the discussion was in Slack.
axelson
force-pushed
the
no-default-tool-versions
branch
from
091079b
to
2950b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the .tool-versions file it makes it easier for users to use their system installed elixir and erlang versions (which is especially helpful on mac because it is difficult/impossible to install older erlang versions).
There is some related discussion in #344 but most of the discussion was in Slack.
However, keep a version specifically for building releases to publish.