Fix formatting on Windows #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring formatting back on Windows. Regression in 0.6.0 Create elixir.yml try without downcase fix cwd Revert test without downcase fix matching fix capture fix missing end r
|
🤕 String.replace that takes a replacement function was added in Elixir 1.9 |
We've just dropped support for elixir 1.7 in 0.6. I wouldn't be happy with dropping 1.8 so soon. |
|
When Elixir 1.11 is out, you can probably drop 1.8. But now, yeah, I agree with you - hence the 🤕 . |
|
Gonna try a new idea. |
princemaple
commented
Oct 6, 2020
| @@ -815,7 +815,7 @@ defmodule ElixirLS.LanguageServer.Server do | |||
|
|
|||
| defp set_project_dir(%{project_dir: prev_project_dir, root_uri: root_uri} = state, project_dir) | |||
| when is_binary(root_uri) do | |||
| root_dir = SourceFile.path_from_uri(root_uri) | |||
| root_dir = root_uri |> SourceFile.path_from_uri() |> Path.absname() | |||
There was a problem hiding this comment.
this normalizes the project_dir path, so it's in "elixir case" (lower c:/)
|
@lukaszsamson @axelson this patch should be mergeable now!
|
axelson
approved these changes
Oct 7, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative PR to #373