Requesting didSave notification in server capabilities #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the server is using didSave notification, it needs to specifically ask for it in the server capabilities. In VS Code it works fine without this, because the editor sends the notification regardless of what server advertises. However, other editors, such as Emacs with lsp-mode, break without this config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of JakeBecker/elixir-ls#175. It's been open there for few months without any feedback, here it probably has a better chance of getting merged.
Since the server is using didSave notification, it needs to specifically ask for
it in the server capabilities. In VS Code it works fine without this, because
the editor sends the notification regardless of what server advertises. However,
other editors, such as Emacs with lsp-mode, break without this config.
I run into this issue in Emacs lsp-mode (emacs-lsp/lsp-ui#300), when I added the %{"save" => true} to the server capabilities in the client, it fixed the problem.