Use elixir 1.15 :root in formatter_for
#890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/language_server/lib/language_server/experimental/code_mod/format.ex
Outdated
Show resolved
Hide resolved
lukaszsamson
approved these changes
May 18, 2023
|
Thanks |
This was referenced Jun 3, 2023
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #526 on elixir 1.15+. see elixir-lang/elixir#12541
I am not a fan of the tests. I was not sure what to add. Everything passes locally but... eh
On the experimental side, I moved to version checking as @lukaszsamson asked. I did not touch the logic on the rest of the file.
Happy to do changes if you prefer.