Suggest funs and modules from metadata #24
Conversation
| @@ -12,6 +12,7 @@ defmodule ElixirSense.Core.Metadata do | |||
| lines_to_env: %{}, | |||
| calls: %{}, | |||
| vars_info_per_scope_id: %{}, | |||
| mods_funs: %{}, | |||
There was a problem hiding this comment.
Is it a good idea to merge this prop with mods_funs_to_positions?
There was a problem hiding this comment.
Yeah, we could have the position in the ModFunInfo struct. However, I think mods_funs_to_positions always keep an entry for {mod, func, nil} as a fallback for cases where we cannot introspect the arity. Ideally, we should start using the new Metadata.get_call_arity/3 (see example here). It works for both functions and types, so we could improve "Go to definition" accuracy.
| @spec find(String.t, [module], [{module, module}], module, [String.t], [String.t], [module], State.scope, String.t) :: [suggestion] | ||
| def find(hint, imports, aliases, module, vars, attributes, behaviours, scope, text_before) do | ||
| @spec find(String.t, [module], [{module, module}], module, [String.t], [String.t], [module], State.scope, %{}, String.t) :: [suggestion] | ||
| def find(hint, imports, aliases, module, vars, attributes, behaviours, scope, mods_and_funs, text_before) do |
There was a problem hiding this comment.
This api needs refactoring
| defp find_hint_mods_funcs(hint, imports, aliases) do | ||
| Application.put_env(:"alchemist.el", :aliases, aliases) | ||
|
|
||
| list1 = Complete.run(hint, imports) |
There was a problem hiding this comment.
I'm pretty sure this is no longer needed as the call Complete.run(hint, env) covers imports and local module calls
There was a problem hiding this comment.
I think the Complete module will eventually need to be refactored or even replaced. It's more complex than it should especially because of the hint stuff, which is a nice feature for iex but I'm not sure it's relevant for editors.
|
@lukaszsamson Let me know if you're still working on this one. if you prefer I can merge it and then we can work on the adjustments later. |
|
@msaraiva I haven't started anything serious besides already committed changes. Let's merge it now as the refafactorings are going to be too big for one PR. |
|
@lukaszsamson great stuff. Thanks! 👍 |
I noticed that module, function and macro suggestions only work for compiled modules. This is irritating when working on unfinished code. With the changes from this PR we are able to make suggestions basing on metadata from currently evaluated piece of code as a fallback if the module is not compiled.
I also did some refactoring in Complete module, most noticeably the aliases are no longer passed through application env