Add some basic configuration for HTML (EEx) files #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobbZ
approved these changes
Oct 3, 2019
|
Hey @NobbZ, thanks for reviewing my PR! Does this project do release cycles? Just wondering why it hasn't been merged. |
|
Not sure about cycles or anything, though I'm grown up in jobs and communities where the rule usually is "reviewer does not merge" ;D We never talked about those formalisms for this repository though. So I'll merge this in. |
|
In my opinion for this repository it is fine for the reviewer to merge the PR. Although I think it would be best if the code author didn't merge the PR's, although as long as the PR has sat for long enough to gather feedback, then it would be fine to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 馃憢 I love this plugin, and wanted to add a little more configuration that I hope will be appreciated. 馃槃
I noticed that there was no included configuration for the "HTML (EEx)" file type, and this resulted in some files in the projects that I work on ending up with trailing whitespace, missing final newlines, that sort of thing. I added some rather conservative configuration for the HTML (EEx) type that I believe most folks can agree on.