Parse histograms with fractional colors #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on a test. The scenario where it came up is taking an image and then reducing colors to 8 and then computing the histogram Mogrify.open(file)
|> Mogrify.custom("-background", "white")
|> Mogrify.custom("-alpha", "remove")
|> Mogrify.custom("-colors", 8)
|> Mogrify.custom("+dither")
|> Mogrify.histogram()I'll see if I can add something in the test suite to prove this out. I've proven it locally by having my app pull in this branch of Mogrify and my test suite for the app (which was previously failing) runs smoothly. |
Problem -------- For some images with very narrow ranges, it appears ImageMagick can return histograms that have fractional color entries. Solution -------- Make the histogram parser optionally look for integer or float color patterns.
bunnymatic
commented
Jan 28, 2021
| %{"alpha" => 255, "blue" => 129, "count" => 4915, "green" => 129, "hex" => "#7F8181", "red" => 127}, | ||
| %{"alpha" => 255, "blue" => 150, "count" => 5913, "green" => 148, "hex" => "#939496", "red" => 147}, | ||
| %{"alpha" => 255, "blue" => 191, "count" => 8142, "green" => 192, "hex" => "#BDC0BF", "red" => 189}, | ||
| %{"alpha" => 255, "blue" => 244, "count" => 58242, "green" => 245, "hex" => "#F4F5F4", "red" => 244} |
There was a problem hiding this comment.
Note: If you take this test and apply to master, you should get the error I encountered
test .histogram with fractional rgb values (MogrifyTest)
test/mogrify_test.exs:504
** (Protocol.UndefinedError) protocol Enumerable not implemented for nil of type Atom. This protocol is implemented for the following type(s): HashSet, Range, Map, Function, List, Stream, Date.Range, HashDict, GenEvent.Stream, MapSet, File.Stream, IO.Stream
code: |> histogram
|
👍 Tanks! |
|
Looks good! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For some images with very narrow ranges, it appears ImageMagick can
return histograms that have fractional color entries.
Solution
Make the histogram parser optionally look for integer or float color patterns.