Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with initialization missing keys for some layers #407

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

seanmor5
Copy link
Contributor

@seanmor5 seanmor5 commented Dec 6, 2022

We originally generated a keys map based on layer names, but there are some differences in how we generated layer names between keys and layers. This fixes by using the IDs. The keys map is internal anyway, and IDs are guaranteed to be unique.

@seanmor5 seanmor5 merged commit 5211bd8 into main Dec 7, 2022
@josevalim josevalim deleted the sm-fix-init-issue branch December 12, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants