Fix event count for multiple handlers #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple event handlers are registered for the same event, the counter is incremented before each handler. This results in filters like `every: 10` to never match any events.
seanmor5
approved these changes
Feb 20, 2024
|
Good catch, thanks! |
|
Could we have a test somehow? 🤔 |
|
@josevalim I'm currently testing it by always adding a second handler in the dummy loop, which causes the existing tests to fail without the fix. Maybe not the most elegant/obvious solution. I'm happy to refactor the test if you point me in the right direction (I'm very new to axon) 😅 |
hwuethrich
force-pushed
the
fix_event_count
branch
from
82bb212
to
44b810c
Compare
|
I've added a test for the event counting. Let me know if this is OK or if you would like me to further refactor the test. |
|
Actually, the test now passes even without the fix because I removed the dummy handlers. Let me re-add them again... |
seanmor5
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple event handlers are registered for the same event, the counter is incremented before each handler. This results in filters like
every: 10to never match any events.