Add CamemBERT #110
Merged
Add CamemBERT #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seanmor5 maybe a single test for camembert-base in the roberta suite? I don't think we need to test all mappings. As for the tokenizer, there is |
jonatanklosko
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested specifically for NER tasks. It's actually just a Roberta model, so there's no new implementation, but the config lists CamemBERT so it throws off our loader.
@jonatanklosko Let me know if you think it is worth adding an extra module of integration tests to make sure all of the mappings load correctly :)
AFAICT there is not a fast tokenizer, but I think users can get around this manually by loading in Python and using
convert_slow_to_fastor whatever the conversion is in Python