Add question answering serving #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmor5
reviewed
Feb 2, 2023
blackeuler
force-pushed
the
main
branch
3 times, most recently
from
2fc8718
to
622c12f
Compare
jonatanklosko
force-pushed
the
main
branch
4 times, most recently
from
6f7171a
to
e1f5893
Compare
|
@blackeuler thanks :) I pushed some adjustments and docs, I think we are all good now. There are some options we may want to support going forward, in particular |
jonatanklosko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some poking around, and I think this is how question answering would be added. I know I need to clean up the docs and some other things like testing but feedback would be appreciated on the overall approach. Thanks so much for the excellent library.