Add conversational serving #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonatanklosko
commented
Feb 24, 2023
•
jonatanklosko
commented
I felt that |
seanmor5
reviewed
Feb 24, 2023
| Each call to serving returns the conversation history, which can be | ||
| fed into the next run to maintain the context. | ||
|
|
||
| Note that either `:max_new_tokens` or `:max_length` must be specified. |
There was a problem hiding this comment.
I think max_length is missing from the options below?
There was a problem hiding this comment.
It's intentional, we do say "Also accepts all the other options of Bumblebee.Text.Generation.build_generate/3" and both :max_new_tokens and :max_length are there. I think :max_new_tokens is common enough that it makes sense to list it here, but it should be preferred over :max_length, and so I didn't include both.
josevalim
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.