Change image size to maps in image featurizers #329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially CLIP was using a single integer as size and always resized the shortest edge. Now it supports both fixed height-width and shortest edge resizing (there is padding on top of it, so the shape is still static).
I updated all featurizers to use maps, such as
%{height: 224, width: 224}
and%{shortest_edge: 224}
. This matches hf/transformers and in the feature we may need to support more of these (for other featurizers).