feat: add custom float precision inspect option #1286
Conversation
| @@ -129,4 +131,56 @@ defmodule Nx.TensorTest do | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe "inspect" do | |||
There was a problem hiding this comment.
@a-alhusaini This PR will introduce a paliative solution for this. The printing format (and maybe the actual option) will change in the future, but it should solve your problem in the short-term.
The changes below contain some examples on the inspected tensors in the "prints with configured precision" test.
For usage in IEx, you can use IEx.configure(inspect: [custom_options: [nx_precision: 5]]) for example.
nx/lib/nx/backend.ex
Outdated
| # convert number to float | ||
| n = if is_float(n), do: n, else: n * 1.0 | ||
|
|
||
| str = float_to_string(n, precision) |
There was a problem hiding this comment.
This code means that, if precision is enabled, 1+2i will always be printed as 1.0+2.0i.
nx/lib/nx/backend.ex
Outdated
| re_str = complex_to_string_real(re, precision) | ||
| im_str = complex_to_string_component(im, precision) | ||
|
|
||
| "#{re_str}#{im_str}i" |
There was a problem hiding this comment.
There is some duplication here. Could this instead be written as:
| re_str = complex_to_string_real(re, precision) | |
| im_str = complex_to_string_component(im, precision) | |
| "#{re_str}#{im_str}i" | |
| re_str = inspect_value(re, precision) | |
| case inspect_value(im, precision) do | |
| "-" <> _ = im_str -> re_str <> im_str <> "i" | |
| "+" <> _ = im_str -> re_str <> im_str <> "i" | |
| im_str -> re_str <> "+" <> im_str <> "i" | |
| end |
The second clause may not be necessary.
nx/lib/nx/backend.ex
Outdated
| defp inspect_value(float, precision) when is_float(float) and is_integer(precision) do | ||
| float_to_string(float, precision) | ||
| end | ||
|
|
||
| defp inspect_value(float, nil) when is_float(float), do: Float.to_string(float) |
There was a problem hiding this comment.
Nitpick. For consistency with complex_to_string, move the precision handling inside?
| defp inspect_value(float, precision) when is_float(float) and is_integer(precision) do | |
| float_to_string(float, precision) | |
| end | |
| defp inspect_value(float, nil) when is_float(float), do: Float.to_string(float) | |
| defp inspect_value(float, precision) when is_float(float), do: float_to_string(float, precision) |
nx/lib/nx.ex
Outdated
| @@ -6133,7 +6133,7 @@ defmodule Nx do | |||
| #Nx.Tensor< | |||
| f64[2][2] | |||
| [ | |||
| [-3.141592653589793, -0.0], | |||
| [-3.141592653589793, 0.0], | |||
There was a problem hiding this comment.
Is this change correct?
There was a problem hiding this comment.
Yes, it was intentional, for consistency with the custom handling of -0.0 in complex_to_string
relates to #1285