Fix :ets.foldl/3 usage on Plug.Upload.terminate/2, add test for it (#582

)
elixir-plug · Jul 29, 2017 · 9c06cad · 9c06cad
1 parent 1a10f7a
commit 9c06cad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/plug/upload.ex b/lib/plug/upload.ex
@@ -167,9 +167,9 @@ defmodule Plug.Upload do
   end
 
   def terminate(_reason, _state) do
-    :ets.foldl(@table, :ok, fn {_pid, _tmp, paths} ->
+    :ets.foldl(fn({_pid, _tmp, paths}, _) ->
       delete_paths(paths)
-    end)
+    end, :ok, @table)
     :ok
   end
 

diff --git a/test/plug/upload_test.exs b/test/plug/upload_test.exs
@@ -23,4 +23,10 @@ defmodule Plug.UploadTest do
         refute File.exists?(path)
     end
   end
+
+  test "terminate removes all files" do
+    {:ok, path} = Plug.Upload.random_file("sample")
+    :ok = Plug.Upload.terminate(:shutdown, [])
+    refute File.exists?(path)
+  end
 end