More flexible encoding configuration #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows setting `:encodings` option, which is a list of potential encodings used in given application. While currently browsers support only Deflate (named `gzip` in header) and Brotli, there is already RFC 8878 [1] which defines Zstd as a potential additional encoding. This approach should provide more flexibility in future when there may be more potential encodings, and adding them one by one as a separate options may scale poorly. [1]: https://datatracker.ietf.org/doc/html/rfc8878
|
LGTM! We only need tests and docs! :) |
hauleth
force-pushed
the
ft/more-flexible-encoding-configuration
branch
from
a1b9ba7
to
f8e6047
Compare
|
@josevalim added documentation and tests (it seems that the |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting
:encodingsoption, which is a list of potential encodings used in given application. While currently browsers support only Deflate (namedgzipin header) and Brotli, there is already RFC 8878 which defines Zstd as a potential additional encoding. This approach should provide more flexibility in future when there may be more potential encodings, and adding them one by one as a separate options may scale poorly.