-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom session cookie serializers #114
Conversation
My original PR (#72) included this feature, but it appears it was removed before merging. @josevalim do you remember why? I'm a 👍 on allowing a serializer to be configured. @cconstantin the only thing I'm not a big fan of is the namespaces for the serializers. Since a serializer could be used for things other than cookies I think |
@scrogson it was removed because it was added as part of the encryptor while it should be a responsibility of the cookie store (as in this pull request). :) |
Ah! Makes sense. |
@josevalim anything you'd change with this PR then? I'm not sure what to expect about how/when feedback is provided. :) |
I am on holidays so I don't have a lot of time for reviewing and merging code lately but I plan to get back to it soon-ish. :) |
Enjoy your time off. :) |
Let's merge this but I would like to propose some changes.
The goal is to make the code simpler and remove abstractions. We need to rebase and improve the docs on the exact API a serializer is required to implement. |
@josevalim updated the code. Any other suggestions? Thanks. |
Add support for custom session cookie serializers
Beautiful ❤️ 💚 💙 💛 💜 |
This is to ease integration with existing applications, in particular rails.
Current behaviour is maintained (serialize to ETF), but support for JSON is added.