Add option to decide what to do on invalid UTF-8 urlencoded params

[bradhanks]

added error_code and byte_position to validate_utf8!
added ascii optimization as found in String.valid?
wrote tests for changes
edited existing tests to incorporate "in position #{byte_position}
added documentation

[josevalim]

It should always raise, and not behave differently based on the format.

[bradhanks]

What information should be in the exception? I guess I'm not exactly clear on what exactly should change with different error codes.

[josevalim]

If you want a way to not raise, then we should create a validate_utf8 that returns {:error, Exception} without raising. But we should not use the status code to control that. It is unclear what is the ultimate gain here.

[josevalim]

There are many changes here. Can you please keep add them granularly? Although I don't think there is a need for position or to change the return type based on the code. It is a function with !, it should always raise.

[bradhanks]

Something like this?

  defp do_validate_utf8!(<<byte, _::bits>>, exception, context, error_code, byte_position) do
    case error_code do
      500 ->
        raise exception,
              "Internal Server Error (500): invalid UTF-8 on #{context}, got byte #{byte}"

      404 ->
        raise exception,
              "Page Not Found (404): invalid UTF-8 on #{context}, got byte #{byte}"

      error_code when error_code in 100..999 ->
        raise exception,
              "Status code #{error_code}: invalid UTF-8 on #{context}, got byte #{byte}"
    end
  end

[josevalim]

No, that does not change how the server is going to respond in any way. Can you take a step back and remind us what is your end goal? :) If you want to change the exception, it would be something like:

defexception [plug_status: Application.compile_env(...)]

When defining the exception being raised.

[RNCST-CEO]

ced8d9a