Add Plug.Conn.request_url/1 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Aug 24, 2017
lib/plug/conn.ex
Outdated
|
|
||
| defp request_url_port(:http, 80), do: "" | ||
| defp request_url_port(:https, 443), do: "" | ||
| defp request_url_port(_, port), do: [?:, to_string(port)] |
There was a problem hiding this comment.
Will do, thanks. Because it saves the indirection of figuring out how to stringify it?
There was a problem hiding this comment.
The counter argument is that the code is now clearer because we always know port is an integer, we don't have to guess what types it may have.
There was a problem hiding this comment.
That's true. Haven't gotten around to changing it yet – want to leave it like this, then?
Personally I kind of like ":#{port}" for readability and brevity, though I understand it may be less performant.
There was a problem hiding this comment.
No worries. I will go ahead and change it and merge then! Since I prefer the more explicit format. :) Thank you!
|
❤️ 💚 💙 💛 💜 |
|
Perfect, thank you @josevalim! 💓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #587.