Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade protobuf to 0.11 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade protobuf to 0.11 #18

wants to merge 1 commit into from

Conversation

htrefil
Copy link

@htrefil htrefil commented Nov 17, 2022

This is a relatively small change.

  • protobuf version spec was set to ~> 0.11 in mix.exs
  • regenerated files using 0.11 compiler

@htrefil
Copy link
Author

htrefil commented Jan 2, 2023

Hey, is there anything I can do to get this merged? Thanks. :)

@davelooi
Copy link

Hi, this would be really good to have. Anything we could help to move this forward? @ethanvaughn

@ericmj
Copy link
Collaborator

ericmj commented Feb 28, 2023

@davelooi Why do you need the upgrade, does anything break when using this library with protobuf 0.11?

@davelooi
Copy link

davelooi commented Mar 2, 2023

Actually, it's not broken. Managed to figure out what was blocking my upgrade. Thanks for responding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanvaughn ethanvaughn ethanvaughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@htrefil @davelooi @ericmj @ethanvaughn