Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax version of telemetry #12

Closed
inhji opened this issue Jan 21, 2022 · 3 comments
Closed

Relax version of telemetry #12

inhji opened this issue Jan 21, 2022 · 3 comments

Comments

@inhji
Copy link
Contributor

inhji commented Jan 21, 2022

Could you relax the version requirement for the telemetry module to allow for 1.0 and 0.4?

New versions of telemetry_poller require telemetry version 1.0.0. Telemetry_poller is included in new phoenix projects. Additionally the 1.0 Version does not introduce any breaking changes, so it would be a safe change to make.

Thank you.
@keathley
Copy link
Member

@inhji No problem. Is this something you'd feel comfortable submitting a PR for?

@inhji
Copy link
Contributor Author

inhji commented Jan 22, 2022

@keathley Definitely! I'll do it in the next few days.

@inhji inhji mentioned this issue Jan 24, 2022
Merged
@inhji inhji closed this as completed Jan 26, 2022
@vasspilka
Copy link

Hello, @keathley could we also create a minor release for this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@inhji @keathley @vasspilka