Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Norm.valid?/2 becomes prohibitively slower after a certain amount of records to validate #65

Open
gesta opened this issue Apr 9, 2020 · 0 comments · May be fixed by #66
Open

Norm.valid?/2 becomes prohibitively slower after a certain amount of records to validate #65

gesta opened this issue Apr 9, 2020 · 0 comments · May be fixed by #66

Comments

@gesta
Copy link

gesta commented Apr 9, 2020

Problem:
A conformity check is building two separate lists, consisting of the valid and invalid records, with a max total sum of the length of the input, which is becoming prohibitively slower after ~30 thousand records.
This holds true for a validation check, as under the hood it performs a conformity check and matches the result.

Proposal:
Optimise the validation check to not keep temporary results, while replicating the conformity check patterns. As an extra bonus (for multiple checks performed under a single validation) the validation stops once any check fails.

@gesta gesta linked a pull request Apr 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant