execute compiler rpc in a task #60
Labels
bug
Something isn't working
Comments
mhanberg
added a commit
that referenced
this issue
Jul 6, 2023
This lets the compiler stdout messgaes to be logged to the client while the RPC is still happening. Previously, the port would message back to the process that was synchronously waiting on the RPC to finish, so it didn't send any log messages to the LSP process until the compiler was done. This made it look like the initial compiler was hanging. Fixes #60
mhanberg
added a commit
that referenced
this issue
Jul 6, 2023
This lets the compiler stdout messgaes to be logged to the client while the RPC is still happening. Previously, the port would message back to the process that was synchronously waiting on the RPC to finish, so it didn't send any log messages to the LSP process until the compiler was done. This made it look like the initial compiler was hanging. Fixes #60
mhanberg
added a commit
that referenced
this issue
Jul 6, 2023
This lets the compiler stdout messgaes to be logged to the client while the RPC is still happening. Previously, the port would message back to the process that was synchronously waiting on the RPC to finish, so it didn't send any log messages to the LSP process until the compiler was done. This made it look like the initial compiler was hanging. Fixes #60
This was referenced Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this will not block the runtime genserver, so that stdout packets from the port can be forwarded to the LSP process and logged correctly.
it currently synchronously compiles, and then logs the pile of log messages.
when it fires off a task (should be a supervised task), it should set some state to lock the server so that other processes can't ask it for data assuming the code is compiled
or a flag to say its compiling, and only allow rpc's that don't care about that
The text was updated successfully, but these errors were encountered: