Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture JS errors and logs in the servers handle_info call #95

Closed
keathley opened this issue Sep 7, 2016 · 2 comments
Closed

Capture JS errors and logs in the servers handle_info call #95

keathley opened this issue Sep 7, 2016 · 2 comments

Comments

@keathley
Copy link
Member

keathley commented Sep 7, 2016

Blocking each webdriver call with a call to check for js errors and logs is an expensive and wasteful process. All of this same information is sent to the server process from phantom. We should be able to capture this information using the same logging capture behaviour and then print logs to the console or throw errors in our respective test. This should work correctly because each phantom is scoped to a single test at a time.

@krankin
Copy link
Contributor

krankin commented Apr 18, 2017

@keathley - So I was playing around with this and had a question about how you want to handle javascript errors on the Genserver side? In the case where we have a javascript error, raising a Wallaby.JSError goes uncaught and crashes the Genserver if you move current logging behavior server side.

We could do something to notify the client, but doesn't that kinda defeat the purpose of this as we'd still be checking for an error on each call in the driver? I still think we can handle logging server side, but I'm looking to you for ideas on what to change for handling js errors?

@keathley
Copy link
Member Author

This is going to be more trouble then its worth for not enough gain. Closing this since there are more high impact places for optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants