You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Blocking each webdriver call with a call to check for js errors and logs is an expensive and wasteful process. All of this same information is sent to the server process from phantom. We should be able to capture this information using the same logging capture behaviour and then print logs to the console or throw errors in our respective test. This should work correctly because each phantom is scoped to a single test at a time.
The text was updated successfully, but these errors were encountered:
@keathley - So I was playing around with this and had a question about how you want to handle javascript errors on the Genserver side? In the case where we have a javascript error, raising a Wallaby.JSError goes uncaught and crashes the Genserver if you move current logging behavior server side.
We could do something to notify the client, but doesn't that kinda defeat the purpose of this as we'd still be checking for an error on each call in the driver? I still think we can handle logging server side, but I'm looking to you for ideas on what to change for handling js errors?
Blocking each webdriver call with a call to check for js errors and logs is an expensive and wasteful process. All of this same information is sent to the server process from phantom. We should be able to capture this information using the same logging capture behaviour and then print logs to the console or throw errors in our respective test. This should work correctly because each phantom is scoped to a single test at a time.
The text was updated successfully, but these errors were encountered: