Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference webpack instead of brunch in README #478

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Reference webpack instead of brunch in README #478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4edad8
Reference webpack instead of brunch in README
mhanberg Nov 1, 2019
90cfc8f
reword
mhanberg Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Assets are not re-compiled when you run `mix test`.
This can lead to confusion if you've made changes in javascript or css but tests are still failing.
There are two common ways to avoid this confusion.

The first solution is to run `brunch watch` from the assets directory.
The first solution is to run `webpack --mode development --watch` from the assets directory.
This will ensure that assets get recompiled after any changes.

The second solution is to add a new alias to your mix config that recompiles assets for you:
Expand All @@ -147,7 +147,9 @@ The second solution is to add a new alias to your mix config that recompiles ass
]

defp compile_assets(_) do
Mix.shell.cmd("assets/node_modules/brunch/bin/brunch build assets/")
Mix.shell().cmd("./assets/node_modules/webpack/bin/webpack.js --mode development",
quiet: true
)
end
```

Expand Down