Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the DependencyError message in chrome.ex #581

Merged
merged 1 commit into from
Dec 23, 2020
Merged

fixes the DependencyError message in chrome.ex #581

merged 1 commit into from
Dec 23, 2020

Conversation

alexandrubagu
Copy link
Contributor

@alexandrubagu alexandrubagu commented Dec 23, 2020

Setting the chromedriver outside the projects doesn't work even if I follow the docs.

** (Mix) Could not start application wallaby: exited in: Wallaby.start(:normal, [])
    ** (EXIT) an exception was raised:
        ** (FunctionClauseError) no function clause matching in Keyword.get/3
            (elixir 1.10.4) lib/keyword.ex:201: Keyword.get("/media/alexandrubagu/devel/utils/chromedriver", :path, "chromedriver")
            (wallaby 0.28.0) lib/wallaby/chrome.ex:174: Wallaby.Chrome.find_chromedriver_executable/0
            (wallaby 0.28.0) lib/wallaby/chrome.ex:157: Wallaby.Chrome.validate/0
            (wallaby 0.28.0) lib/wallaby.ex:31: Wallaby.start/2

Solution:

  • change: config :wallaby, chromedriver: "/media/alexandrubagu/devel/utils/chromedriver"
  • to: config :wallaby, :chromedriver, path: "/media/alexandrubagu/devel/utils/chromedriver"

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #581 (49b502b) into main (11a9ec8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          24       24           
  Lines         939      939           
=======================================
  Hits          862      862           
  Misses         77       77           
Flag Coverage Δ
IntegrationTest 87.43% <ø> (ø)
UnitTest 41.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/wallaby/chrome.ex 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a9ec8...49b502b. Read the comment docs.

Copy link
Member

@mhanberg mhanberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mhanberg mhanberg merged commit 2786b0f into elixir-wallaby:main Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants