Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put metadata into useragent for Firefox #614

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Conversation

mhanberg
Copy link
Member

@mhanberg mhanberg commented Aug 1, 2021

This enables async tests while using the default selenium configuration.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2021

Codecov Report

Merging #614 (23f13c1) into main (5557024) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   91.79%   91.81%   +0.01%     
==========================================
  Files          24       24              
  Lines         939      941       +2     
==========================================
+ Hits          862      864       +2     
  Misses         77       77              
Flag Coverage Δ
IntegrationTest 87.46% <100.00%> (+0.02%) ⬆️
UnitTest 41.55% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/wallaby/selenium.ex 76.82% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5557024...23f13c1. Read the comment docs.

This enables async tests while using the default selenium configuration.
@mhanberg mhanberg merged commit 1577ec0 into main Aug 1, 2021
@mhanberg mhanberg deleted the mh/async-fixing-selenium branch August 1, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants