has_css? should return a boolean. Fix for Issue: #585. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the has_css?/2 method was using find/1 instead of has?/1 causing it to throw an error instead of a boolean
BrooklinJazz
changed the title
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
==========================================
+ Coverage 91.81% 92.02% +0.21%
==========================================
Files 24 24
Lines 941 941
==========================================
+ Hits 864 866 +2
+ Misses 77 75 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adkron posted an issue: #585 that the
has_css?/2function was raising an exception.This is my first PR in the project, and I'm new to open source 馃檹 Please let me know if I'm breaking any rules or need to adjust anything!
the
has_css?/2method was usingfind/1instead ofhas?/1causing it to throw an error instead of returning a boolean.I've added testing and made test names consistent for has_css?/2, has_css/3, has_no_css?/2, and has_no_css/3 to make sure all work as expected.