-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependencies and test on Elixir 1.14 and 1.15 #738
Draft
kyleboe
wants to merge
8
commits into
elixir-wallaby:main
Choose a base branch
from
kyleboe:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fa26efe
Update elixir-otp matrix to include 1.14 and 1.15
kyleboe 2fb5f89
update dependencies to reflect modern elixir
kyleboe cfb508e
Update usage of ExUnit.Server.modules_loaded for modern elixir
kyleboe 982ea5b
drop unsupported elixir/otp versions
kyleboe 805dcdf
update test to match HTTPoison error format
kyleboe bd1e533
update benchee for modern elixir
kyleboe 1b98529
add back elixir 1.12 and 1.13 and adjust services for ubuntu selenium
kyleboe d70a952
add check for function export
kyleboe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove 1.12 and 1.13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because they are not backwards compatible with the changed dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will likely require a major version bump to signify this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to drop support for older versions of Elixir just for a dev dependency that I have never even used since taking over the project.
you can probably add
--only testto mix deps.get in CI to avoid having to update benchee.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am down to drop benchee as a dependency altogether. However there are other changes around
ExUnit.Server.modules_loaded()that are not backwards compatible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is a private elixir API, and is in a unit test.
I would just add a conditional that checks if the function is exported and call the one that is
function_exported?(ExUnit.Server, :modules_loaded, 0), etc